Do not hardcode "/v22" in the source code
As of now, rdbnomics provides 2 options: api_base_url
and api_version
.
I understand that this line in rdb
concatenates both.
This prevents using rdbnomics with another instance, like https://ipp.staging.db.nomics.world/ because, even if we set the api_base_url option to "api.ipp.staging.db.nomics.world"
, the rdb
function will add the /v22
prefix, which does not exist by default. Actually the /v21
, /v22
, etc. prefixes are not part of the dbnomics-api application, they are handled at the reverse-proxy level.
Could api_version option be removed and the prefix embedded in the default value of api_base_url
? That's how the Python client is done by the way.