Skip to content
Snippets Groups Projects

WIP: #45 - WTO: Write datasets in JSON repo for "annually" category

Closed Bruno Duyé requested to merge dev into master
All threads resolved!

Merge request for management#45 (closed)

Merge request reports

Approval is optional

Closed by (Mar 13, 2025 9:51pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christophe Benz
  • Christophe Benz
  • Christophe Benz
  • I know I did not review only the purpose of this merge request, which is only about writing datasets.

    It seems good to me, except the call to validate_dataset (see this comment)

    So, waiting.

  • assigned to @bduye

  • Bruno Duyé added 4 commits

    added 4 commits

    • 519d71e2 - Use skip_series_duplicates_checking option of validate_dataset
    • d47c085d - minor: move dataset.json code after series.json writing
    • 7ee45939 - Merge remote-tracking branch…
    • 9c90d589 - minor: code refactor

    Compare with previous version

    Toggle commit list
  • Bruno Duyé added 1 commit

    added 1 commit

    • 9a39c0cd - Minor: add assert to ensure all found units are the same on each CSV files

    Compare with previous version

  • Bruno Duyé added 1 commit

    added 1 commit

    • ad981fe8 - Minor: rewording ("unexpected")

    Compare with previous version

  • Bruno Duyé added 1 commit

    added 1 commit

    • 6d1addd4 - FIx: adapt to dbnomics-converters -

    Compare with previous version

  • Bruno Duyé added 2 commits

    added 2 commits

    • 4fd01c67 - Fix: adapt to dbnomics-converters validate_dataset() argument renaming
    • 06c24e40 - Minor: make use of {!r} trick

    Compare with previous version

  • Bruno Duyé resolved all discussions

    resolved all discussions

  • Author Contributor

    @cbenz : !4 (merged) is merged => you can now review here

  • assigned to @cbenz

  • Bruno Duyé added 1 commit

    added 1 commit

    • 3057aff8 - follow converters renames: verified_value() => assert_no_error()

    Compare with previous version

  • Bruno Duyé added 1 commit

    added 1 commit

    Compare with previous version

  • I could run the converter script on my machine, it works.

    Not merging this merge-request because branch dev contains more things than the issue #45

  • Please register or sign in to reply