Add compatibility for Internet Explorer / Edge

• As a user
• I want to consult DBnomics web site with Internet Explorer

Acceptance criteria

• The web site MUST be usable with Internet Explorer (at least version 11) as well as Edge
• in particular, using facets
• in particular, displaying charts

Tasks

• setup babel plugin in webpack/rollup

Currently, connecting to next.nomics.world with IE returns a blank page.

As @thomasbrand is demonstrating DBnomics under IE11, let's raise the priority of this issue.

• I added babel-polyfill in https://git.nomics.world/dbnomics/dbnomics-ui/commit/a5304bfe50eae79178ab17f2d1c36fb404bdef3b to solve "Symbol is undefined" error.
• There is still an error with https://developer.mozilla.org/fr/docs/Web/API/NodeList/forEach#Polyfill

• I added https://github.com/imagitama/nodelist-foreach-polyfill in https://git.nomics.world/dbnomics/dbnomics-ui/commit/d9fb1f8d9bf7d261f6837abaf0cbdd6207d389d5

• I added https://github.com/javan/details-element-polyfill in https://git.nomics.world/dbnomics/dbnomics-ui/commit/b516ffdb9a82130c9edeec36f3d96909119c3822 for the category tree

... version 11

added Doing label

assigned to @cbenz

added ~143 and removed Doing labels

closed

Feedback from a user:

When I accessed the site with Microsoft Edge (44.17763.1.0), the filters for selecting series were not working (e.g., only look at quarterly series)

On MS Edge, console logs

SCRIPT1028: Expected identifier, string or number

Apparently MS Edge doesn't support object property rest syntax (https://stackoverflow.com/questions/53628191/edge-script1028-expected-identifier-string-or-number)

Updates have to be done in ui code.

Currently the JavaScript bundle generated by webpack is not transformed by Babel for browser compatibility.

As said with @pdi the step to solve this issue is to add babel-loader to the client-side rules of the webpack config.

I think that "babel-loader" should be added last, after "ify-loader".

reopened

changed the description

added 1h 15m of time spent at 2019-05-10

Next steps would have to be decided, by weighting the pros and cons:
What would the Edge compatibility cost? (to change the code and to maintain it? would the performances be affected?) Do we support Internet Explorer too? what versions?

All in all, I don't think this is a big priority, compared to other issues.

@pdi makes a good remark: according to the web analytics, IE+Edge users make up about 10 % of the visits on DBnomics. This is not negligeable and has to be taken into account.

Similar numbers on Data.gouv.fr

IE 10/11 use the Trident engine which will be supported until 2020 at least. Edge currently uses the EdgeHTML engine and will soon (?) use Chrome's Blink engine.

changed title from UI: add compatibility for IE to Add compatibility for Internet Explorer / Edge

added Doing label

@MichelJuillard DBnomics now works with MS Edge, thanks to @cbenz

added 3h of time spent at 2019-05-14

Excellent, @pdi !

closed

IE11 compatibility needs to be checked again: #462 (closed)