Skip to content
Snippets Groups Projects

Implement download script and more

Closed Christophe Benz requested to merge dev into init
Edited by Christophe Benz

Merge request reports

Approval is optional

Closed by (Mar 13, 2025 11:49pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dares_settings.py 0 → 100644
    121 "file_nb": 2
    122 },
    123 {
    124 "name":"Le temps partiel",
    125 "page_slug": "le-temps-partiel",
    126 "file_nb": 1
    127 },
    128 {
    129 "name": "Les tensions sur le marché du travail par métier",
    130 "page_slug": "les-tensions-sur-le-marche-du-travail-par-metier",
    131 "file_nb": 2
    132 }
    133 ]
    134
    135 # TESTS
    136 assert(len(TOP_CATEGORIES) == TOP_CATEGORIES_NB), "Wrong number of top categories required"
  • Christophe Benz
  • Here is my review.

    Do not take them as requirements, I let you judge about what to do or not given the time it takes :smiley:

    Here is an additional general recommendation: try to make commit messages starting with a verb and being a short sentence (read more if you'd like here.

    Now I'm going to try to execute the download script.

    Thanks!

  • Christophe Benz
  • I executed the script dares_to_dbnomics.py.

    Without using the --push option, it made a commit in the source data repository, but also pushed it to GitLab. Can you fix it?

    You can make the 2 scripts executable, to homogenize with the other fetchers.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply