Commit f511f2bf authored by Christophe Benz's avatar Christophe Benz
Browse files

Add TODOs

parent a1eebe57
Pipeline #353220 failed with stage
in 1 minute and 3 seconds
......@@ -177,12 +177,14 @@ class Storage(abc.ABC):
}
for dimension_code, dimension_value_code in series.metadata.dimensions.items():
if dimension_code not in dimension_code_index:
# TODO should be a warning because dataset metadata only defines labels
yield DimensionError(
f"Dimension {dimension_code!r} is referenced by series {series_code!r} "
f"of dataset {dataset_code!r} but was not found in dataset metadata"
)
continue
if dimension_value_code not in dimension_code_index[dimension_code]:
# TODO should be a warning because dataset metadata only defines labels
yield DimensionError(
f"Dimension value {dimension_value_code!r} is referenced by series {series_code!r} "
f"of dataset {dataset_code!r} but was not found in dataset metadata"
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment